Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete version testing #107

Merged
merged 4 commits into from
Oct 15, 2020
Merged

feat: delete version testing #107

merged 4 commits into from
Oct 15, 2020

Conversation

zekth
Copy link
Member

@zekth zekth commented Sep 15, 2020

Following fastify/fastify#2549 , delete the version check as now it's in Fastify itself.

Checklist

fox1t
fox1t requested changes Sep 15, 2020
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugin.js Show resolved Hide resolved
@mcollina mcollina added the semver-major Issue or PR that should land as semver major label Sep 15, 2020
@mcollina
Copy link
Member

Is this semver-major or not? I might be tempted to ship it as minor.

@L2jLiga
Copy link
Member

L2jLiga commented Sep 15, 2020

It breaks plugin validation unless newer version of fastify is installed so it's major IMO

@zekth
Copy link
Member Author

zekth commented Sep 15, 2020

It breaks plugin validation unless newer version of fastify is installed so it's major IMO

That's my concern yes as long as there is no pointer to Fastify instance to check if it's >=3.4

jsumners
jsumners reviewed Sep 15, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

RafaelGSS
RafaelGSS approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@L2jLiga L2jLiga requested a review from fox1t September 16, 2020 09:00
@mcollina
Copy link
Member

@jsumners @delvedor any options on this? I would like to ship this asap.

delvedor
delvedor approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsumners
jsumners approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit e056281 into fastify:master Oct 15, 2020
@zekth zekth deleted the add_version_check branch October 15, 2020 15:50
@minhvietbui minhvietbui mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@fox1t fox1t fox1t approved these changes

@delvedor delvedor delvedor approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
semver-major Issue or PR that should land as semver major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zekth @mcollina @L2jLiga @jsumners @fox1t @delvedor @RafaelGSS