-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fastify and trim -rc.N suffixes #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we trim also the version number passed as option to fastify-plugin
?
@delvedor I don't think so:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Well one of you guys will have to merge. I do not have access to this repo. |
done
Il giorno ven 9 feb 2018 alle ore 01:13 James Sumners <
notifications@github.com> ha scritto:
… Well one of you guys will have to merge. I do not have access to this repo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADL40QLSyGm9DJOCyUbiXA0S5tEhCwsks5tS42ngaJpZM4R9hsX>
.
|
Implements the solution proposed by @mcollina in fastify/fastify#763 .