Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fastify and trim -rc.N suffixes #21

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

jsumners
Copy link
Member

@jsumners jsumners commented Feb 7, 2018

Implements the solution proposed by @mcollina in fastify/fastify#763 .

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we trim also the version number passed as option to fastify-plugin?

@jsumners
Copy link
Member Author

jsumners commented Feb 8, 2018

@delvedor I don't think so:

% cat package.json|jq                                                                                                                                
{
  "dependencies": {
    "fastify": "^1.0.0-rc.1",
    "fastify-plugin": "file:/Users/jsumners/Projects/oss/fastify-plugin"
  }
}
% cat foo.js                                                                                                                                             
'use strict'

const fp = require('fastify-plugin')

const plugin = fp(function (fastify, opts, next) {
  console.log('plugin works')
  next()
}, {
  fastify: '>=1.0.0-rc.1'
})

plugin({}, null, (err) => {
  if (err) throw err
  console.log('done')
})
% node foo.js                                                                                                                                              
plugin works
done

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners
Copy link
Member Author

jsumners commented Feb 9, 2018

Well one of you guys will have to merge. I do not have access to this repo.

@mcollina mcollina merged commit 2713f82 into fastify:master Feb 9, 2018
@mcollina
Copy link
Member

mcollina commented Feb 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants