Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add updates for v3 tsc support #81

Closed
wants to merge 2 commits into from
Closed

add updates for v3 tsc support #81

wants to merge 2 commits into from

Conversation

Ethan-Arrowood
Copy link
Member

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Updated for Fastify v3 typescript changes.

Consider this PR invalid until Fastify 3 is released.

mcollina
mcollina reviewed Dec 24, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Ethan-Arrowood Ethan-Arrowood mentioned this pull request Mar 23, 2020
Merged
4 tasks
@ekoeryanto
Copy link

Consider this PR invalid until Fastify 3 is released.
🆙 🆙 🆙

@mcollina mcollina closed this Jun 22, 2020
@ekoeryanto
Copy link

ekoeryanto commented Jun 22, 2020 •
edited

we need a fix for options types issue on fastify v3 which is just declared only as optional string

@Eomm Eomm added the wontfix This will not be worked on, the behavior is intended label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

Assignees
No one assigned
Labels
wontfix This will not be worked on, the behavior is intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ethan-Arrowood @ekoeryanto @mcollina @Eomm