perf: use map for the in-memory store #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: kibertoad/toad-cache#40
Benchmark: kibertoad/nodejs-benchmark-tournament#12
TLDR, I've discovered a 50%+ improvement in the lookup performance of non-numeric keys when a map is used instead of an object
In
rate-limit
, the key of a request is by default its IP address, so we should benefit directly from the change