Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/retry on 503 #200

Merged
merged 8 commits into from Sep 30, 2021
Merged

Conversation

leorossi
Copy link
Contributor

Will always retry on 503 errors, unless the user does not include GET in retryMethods option.

Fixes: #193

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1286085876

  • 0 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 97.059%

Totals Coverage Status
Change from base Build 1283261490: 0.1%
Covered Lines: 282
Relevant Lines: 286

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 29, 2021

Pull Request Test Coverage Report for Build 1290640037

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 97.255%

Totals Coverage Status
Change from base Build 1283261490: 0.3%
Covered Lines: 284
Relevant Lines: 288

💛 - Coveralls

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test/retry-on-503.js Outdated Show resolved Hide resolved
test/retry-on-503.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test/retry-on-503.js Outdated Show resolved Hide resolved
test/retry-on-503.js Outdated Show resolved Hide resolved
test/retry-on-503.js Outdated Show resolved Hide resolved
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

index.js Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 8d8026f into fastify:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle 503 and Retry-After header
5 participants