Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spwan pool on request when use agent #207

Merged
merged 2 commits into from Oct 26, 2021
Merged

fix: spwan pool on request when use agent #207

merged 2 commits into from Oct 26, 2021

Conversation

climba03003
Copy link
Member

Fixes #206

Agent is actually using origin to determine the Pool that should be used. We do not need to spawn it ourselves.

https://github.com/nodejs/undici/blob/30bea0662a46212be1e4b6d81b37c22858ab8142/lib/agent.js#L107-L122

Checklist

@climba03003
Copy link
Member Author

cc @artur-ma

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1383920697

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.7%) to 94.605%

Totals Coverage Status
Change from base Build 1379979487: -2.7%
Covered Lines: 276
Relevant Lines: 290

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 26, 2021

Pull Request Test Coverage Report for Build 1384390991

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 97.297%

Totals Coverage Status
Change from base Build 1379979487: -0.01%
Covered Lines: 285
Relevant Lines: 289

💛 - Coveralls

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@climba03003 climba03003 merged commit 6a31087 into fastify:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New undici pool is created on each request
3 participants