Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove middie usage #131

Merged
merged 1 commit into from
Aug 30, 2022
Merged

test: remove middie usage #131

merged 1 commit into from
Aug 30, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Aug 30, 2022

Used in tests but not explicitly defined as dependency:

const middie = require('middie')

Checklist

@kibertoad
Copy link
Member

I don't think we actually need middie there, I assume we can just drop it instead

@climba03003
Copy link
Member

middie added on #7
Maybe just an issue of copy and paste.

@kibertoad
Copy link
Member

yeah, there is even a comment thread on that PR discussing how middie is not needed

@Fdawgs Fdawgs changed the title build(deps-dev): add middie test: remove middie usage Aug 30, 2022
@climba03003 climba03003 merged commit 0701e56 into master Aug 30, 2022
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch August 30, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants