Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#136 defaultStoreValues can be set as function #137

Merged
merged 2 commits into from
Oct 27, 2022
Merged

#136 defaultStoreValues can be set as function #137

merged 2 commits into from
Oct 27, 2022

Conversation

gbalcewicz
Copy link
Contributor

Implements feature proposal #136 introducing possibility to set defaultStoreValues option as a factory function.

zrosenbauer
zrosenbauer approved these changes Oct 25, 2022
View reviewed changes
Copy link

@zrosenbauer zrosenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the types change? We use tsd.

mcollina
mcollina approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 307967d into fastify:master Oct 27, 2022
@voxpelli voxpelli mentioned this pull request Jun 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@kibertoad kibertoad kibertoad approved these changes

@zrosenbauer zrosenbauer zrosenbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gbalcewicz @mcollina @kibertoad @zrosenbauer