New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change requestContextPlugin.spec.js status code from 204 to 200 #177

Merged

Eomm merged 1 commit into fastify:master from alfonsograziano:tests-fix-reply-status

Dec 18, 2023

Contributor

alfonsograziano commented Dec 18, 2023 •

edited

Fixes #175

In the current send, we're actually sending an object with a value, so probably the 200 status code is better instead of a no content code

Checklist

run npm run test
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct


          fix: changing status from 204 to 200

alfonsograziano mentioned this pull request

fix: refactor requestContextPlugin.spec.js to use response headers #176

Open

4 tasks

Eomm approved these changes

View reviewed changes

Eomm merged commit 54d5390 into fastify:master

19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment