Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with passing in non-draft 7 AJV instance. Issue 107 #108

Merged
merged 2 commits into from Mar 20, 2024

Conversation

nicobuzeta
Copy link
Contributor

@nicobuzeta nicobuzeta commented Mar 13, 2024

Fixes issue 107 by using the base class of AJV to validate the AJV instance that is passed in.

(I don't usually use JavaScript, but I think this should solve my issue, since all AJV validators inherit from this class)

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added (No changes needed as one expects custom AJV instances to be supported in current documentation)
  • commit message and code follows the Developer's Certification of Origin
    and the Code of conduct

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a7f445b into fastify:master Mar 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants