Optional trailing "/" after prefix

[jennyEckstein]

🐛 Bug Report

I am trying to serve static content over /docs prefix, but being redirected to /docs/ since trailing slash is appended by default.

To Reproduce

Register route with prefix that does not have trailing /, start application, assuming everything done right static content in docs folder will be available at /docs/ instead of /docs.

app.register(fastifyStatic, {
    root: path.join(__dirname, 'docs'),
    prefix: '/docs'
  });

Expected behavior

Static content be available at /docs instead of /docs/.

Your Environment

• node version: 12
• fastify version: 2.13.1
• os: Linux

[nwoltman]

Try setting Fastify's ignoreTrailingSlash option to true.

const fastify = require('fastify')({
  ignoreTrailingSlash: true
})

[jennyEckstein]

Try setting Fastify's ignoreTrailingSlash option to true.

const fastify = require('fastify')({
  ignoreTrailingSlash: true
})

This won't work in my use case since, I am not using fastify directly, rather building an object and passing it to a module that creates fastify. Can the same flag be implemented in fastify-static?

const fastifyStatic = require('fastify-static');
async function registerRoutes(app) {
  app.register(fastifyStatic, {
    prefix: '/docs',
    root: path.join(__dirname, '../docs')
  });
  app.get('/foo', async (req, res)
}
// external module takes function to build routes
buildRoutes(registerRoutes);

[mcollina]

Unfortunately that option is specific to fastify router, so you cannot set it on the module itself.

fastify-static/index.js

Lines 125 to 130 in e1ad93b

	if (opts.redirect === true && prefix !== opts.prefix) {
	fastify.get(opts.prefix, schema, function (req, reply) {
	const parsed = url.parse(req.raw.url)
	reply.redirect(301, parsed.pathname + '/' + (parsed.search || ''))
	})
	}

is the code that does the actual logic. Have you tried putting prefix: false?

Would you like to send a PR for a different option that implement what you need?

[jennyEckstein]

So, I tried the option ignoreTrailingSlash: true and it still appends trailing slash :sad

However, if I modify

fastify-static/index.js

Line 110 in e1ad93b

const prefix = opts.prefix[opts.prefix.length - 1] === '/' ? opts.prefix : (opts.prefix + '/')

to

const prefix = opts.prefix[opts.prefix.length - 1] === '/' ? opts.prefix : opts.prefix;

My static content is served at /docs without trailing slash, just like I need. I can make a PR to make it optional with the flag.

[mcollina]

That'd be rad, thanks!

[Eomm]

Released in 2.7.0

Thank you for your contribution!