-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to avoid trailing slash in prefix #123
Conversation
Great work! Would you mind to add a test for the new type as well as a few of new test for the option (instead of changing existing ones!). Thanks! |
The test, that I altered was failing with my changes, since previously /static would have returned "Not Found" and now it returns 200. plugginOptions for "register /static" block now specifies prefixAvoidTrailingSlash = true, I thought of repurposing the test. |
Great work! Could you add a test for the type in test/types/index.ts? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 9f8657d.
#122
Add flag prefixAvoidTrailingSlash to avoid appending trailing slash to specified prefix.
Checklist
npm run test
andnpm run benchmark
(there is no benchmark script)