Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options overload parameter to sendFile function (#238) #239

Merged
merged 8 commits into from
Oct 5, 2021
Merged

Add options overload parameter to sendFile function (#238) #239

merged 8 commits into from
Oct 5, 2021

Conversation

mav-rik
Copy link
Contributor

@mav-rik mav-rik commented Oct 2, 2021 •
edited by mcollina

Fixes #238

Checklist

@mav-rik mav-rik mentioned this pull request Oct 2, 2021
Closed
2 tasks
mcollina
mcollina requested changes Oct 2, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update the README as well?

@mav-rik
Copy link
Contributor Author

mav-rik commented Oct 3, 2021

@mcollina done

mcollina
mcollina approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Eomm
Eomm reviewed Oct 3, 2021
View reviewed changes
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a hint

index.js Outdated Show resolved Hide resolved
@mav-rik @Eomm
fix(minor): remove default value for options from sendFile
2f207c5 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
mcollina
mcollina approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtym

@mav-rik
Copy link
Contributor Author

mav-rik commented Oct 5, 2021

@mcollina is it ready to be merged? Any more approves needed?

@mcollina
Copy link
Member

mcollina commented Oct 5, 2021

I just needed to ship a security release for this module. Landing this now.

@mcollina mcollina merged commit 8da6140 into fastify:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options overload parameter to sendFile function
3 participants
@mav-rik @mcollina @Eomm