Forward errors to Fastify instead of sending custom error pages #27
Conversation
|
Can you please rephrase the setNotFound problem? It might look like a bug in fastify. |
nwoltman
force-pushed
the
forward-errors
branch
from
1458f84
to
f1d49a6
Compare
nwoltman
force-pushed
the
forward-errors
branch
from
f1d49a6
to
e1cd038
Compare
|
I rewrote the information about errors and put it in a "Handling Errors" section after the "Options" section. |
README.md
Outdated
| [`fastify.setErrorHandler()`](https://www.fastify.io/docs/latest/Server-Methods/#seterrorhandler). | ||
|
|
||
| If a request matches the URL `prefix` but a file cannot be found for the request, | ||
| a `404 Not Found` error will be created and passed to Fastify's error handler. |
There was a problem hiding this comment.
I think this behavior might be wrong. We should really flow this through the notFoundHandler.
There was a problem hiding this comment.
Yes that would be better. From looking at https://github.com/fastify/fastify/blob/master/fastify.js I think one way to do that would be for fastify-static to have access to Fastify's fourOhFour router so that it can call fourOhFour.lookup(req, res). Do you agree?
There was a problem hiding this comment.
I recal (but I might be wrong, I’m from a phone) that Every plugin has its own 404 handler defined, so we should just use that.
There was a problem hiding this comment.
Yes you're right. I figured out how to call the 404 handler and I've updated the PR :)
| if (err.statusCode === 403) return serve403(req, reply.res) | ||
| serve500(req, reply.res) | ||
| if (err.status === 404) { | ||
| fastify._404Context.handler(request, reply) |
There was a problem hiding this comment.
I’m not a huge fan of accessing a private propery. I think we should expose the handler through a documented method.
There was a problem hiding this comment.
Sure. What do you think that should look like? fastify.callNotFoundHandler(request, reply)? Or maybe add it to the reply object as reply.notFound()?
There was a problem hiding this comment.
Okay 👍 I'll propose this in Fastify with a PR
Fixes #17
@mcollina I hope this is what you meant as the solution to #17. Let me know if it isn't. I couldn't find any way to handle 404s withsetNotFoundHandlerso I made it clear in the docs that 404 errors will be passed to Fastify's error handler.