Support compressed assets #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvedor
reviewed
Apr 10, 2018
package.json
Outdated
| "send": "^0.16.0" | ||
| }, | ||
| "devDependencies": { | ||
| "coveralls": "^3.0.0", | ||
| "fastify": "^1.1.1", | ||
| "fastify-compress": "^0.5.1", | ||
| "pre-commit": "^1.2.2", | ||
| "proxyquire": "^2.0.0", | ||
| "request": "2.83.0", |
There was a problem hiding this comment.
I guess you can remove request.
delvedor
reviewed
Apr 10, 2018
example/server-compress.js
Outdated
|
|
||
| fastify | ||
| // compress everything | ||
| .register(require('fastify-compress'), { global: true, threshold: 0 }) |
There was a problem hiding this comment.
You don't need global: true it's the default ;)
|
@delvedor done. |
nwoltman
approved these changes
Apr 10, 2018
This was referenced Apr 10, 2018
allevo
reviewed
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
The implementation of this is very hacky, and it's needed as
senddoes not play nice with fastify lifecycle. It also introduces some overhead.Fixes #45.