Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): use IIFE to ensure proper loading of plugins #114

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fix(examples): use IIFE to ensure proper loading of plugins #114

merged 1 commit into from
Dec 24, 2023

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Dec 24, 2023 •
edited

This is a follow up for #113

Checklist

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 24, 2023
View reviewed changes
examples/collection-format.js Dismissed Show dismissed Hide dismissed
examples/json-in-querystring.js Dismissed Show dismissed Hide dismissed
mcollina
mcollina approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 532770a into master Dec 24, 2023
25 of 31 checks passed
@Uzlopak Uzlopak deleted the fix-examples branch December 24, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@gurgunday gurgunday gurgunday approved these changes

@Fdawgs Fdawgs Awaiting requested review from Fdawgs

@jsumners jsumners Awaiting requested review from jsumners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uzlopak @mcollina @gurgunday