Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e tests with playwright #99

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Conversation

msebastianb
Copy link
Contributor

Changes

  • Add and configure playwright to the project
  • Add command to run tests
  • Implement some tests for current features

Closes #98

Checklist

.gitignore Outdated Show resolved Hide resolved
playwright.config.js Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 8, 2023

Hmm. problem is, that automerge is in the ci.yml and playwright is not taken into account. So it could result in merging a PR despite the playwright wf failed.

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. problem is, that automerge is in the ci.yml and playwright is not taken into account. So it could result in merging a PR despite the playwright wf failed.

I think we could merge this new job in the existing one:
https://github.com/fastify/fastify-swagger-ui/blob/master/.github/workflows/ci.yml

then we can run playwright first if I'm not wrong

.github/workflows/playwright.yml Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
msebastianb and others added 2 commits November 10, 2023 09:29
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 10, 2023

maybe put everything into the test script of package.json/npm.

Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its odd because the integration tests should run after the unit tests, but it works for me...

But lets see what the others say.

@Fdawgs
Copy link
Member

Fdawgs commented Nov 14, 2023

CI isn't happy :/

@msebastianb
Copy link
Contributor Author

@Fdawgs WDYM?

@Fdawgs
Copy link
Member

Fdawgs commented Nov 14, 2023

@Fdawgs WDYM?

It's happy now, don't worry 😊

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit aee66c4 into fastify:master Nov 15, 2023
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests to avoid regressions
5 participants