Default pkg to empty object in case readPackageJson fails (#354)

* Default pkg to empty object in case readPackageJson fails

* update readPackageJson to return an empty object on exception rather than calling done

* update readPackageJson usages and remove unnecessary references to done

* add test case

lib/spec/openapi/utils.js

@@ -35,8 +35,8 @@ function prepareDefaultOptions (opts) {
   }
 }
 
-function prepareOpenapiObject (opts, done) {
-  const pkg = readPackageJson(done)
+function prepareOpenapiObject (opts) {
+  const pkg = readPackageJson()
   const openapiObject = {
     openapi: '3.0.3',
     info: {

lib/spec/swagger/utils.js

@@ -45,8 +45,8 @@ function prepareDefaultOptions (opts) {
   }
 }
 
-function prepareSwaggerObject (opts, done) {
-  const pkg = readPackageJson(done)
+function prepareSwaggerObject (opts) {
+  const pkg = readPackageJson()
   const swaggerObject = {
     swagger: '2.0',
     info: {

lib/util/common.js

@@ -92,11 +92,11 @@ function resolveLocalRef (jsonSchema, externalSchemas) {
   return resolveLocalRef(externalSchemas[localRef], externalSchemas)
 }
 
-function readPackageJson (done) {
+function readPackageJson () {
   try {
     return JSON.parse(fs.readFileSync(path.join(__dirname, '..', '..', 'package.json')))
   } catch (err) {
-    return done(err)
+    return {}
   }
 }
 

test/mode/static.js

@@ -6,6 +6,7 @@ const Fastify = require('fastify')
 const fastifySwagger = require('../../index')
 const fastifySwaggerDynamic = require('../../lib/mode/dynamic')
 const yaml = require('js-yaml')
+const Swagger = require('swagger-parser')
 
 const resolve = require('path').resolve
 const readFileSync = require('fs').readFileSync
@@ -803,3 +804,42 @@ test('/documentation/uiConfig can be customize', t => {
     t.strictEqual(res.payload, '{"docExpansion":"full"}')
   })
 })
+
+test('should still return valid swagger object when missing package.json', t => {
+  const config = {
+    mode: 'dynamic',
+    specification: {
+      path: './examples/example-static-specification.json'
+    },
+    exposeRoute: true
+  }
+
+  t.plan(3)
+  const fastify = Fastify()
+  fastify.register(fastifySwagger, config)
+
+  const originalPathJoin = path.join
+  const testPackageJSON = path.join(__dirname, 'missing.json')
+
+  path.join = (...args) => {
+    if (args[3] === 'package.json') {
+      return testPackageJSON
+    }
+    return originalPathJoin(...args)
+  }
+
+  fastify.ready(err => {
+    t.error(err)
+
+    const swaggerObject = fastify.swagger()
+    t.is(typeof swaggerObject, 'object')
+
+    Swagger.validate(swaggerObject)
+      .then(function (api) {
+        t.pass('Swagger object is still valid.')
+      })
+      .catch(function (err) {
+        t.fail(err)
+      })
+  })
+})