Support, openapi spec added

[Adityapanther]

issue fixed

#343
#47

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[mcollina]

Good work!

[Adityapanther]

No, I removed

[kibertoad]

Thank you! Can you add tests for new formats? Also CI is broken.

[Adityapanther]

@kibertoad everything now good except CI, can you check CI because I have no experience with that or you can guide me for that

[kibertoad]

@Adityapanther See https://github.com/fastify/fastify-swagger/pull/458/checks?check_run_id=3455446735
tests are failing.

[Adityapanther]

ok, thanks

[Eomm]

At every validation execution, we are creating a new ajv instance and compilation.
We must avoid it.

If you precompile the functions, it should work as well

[Adityapanther]

can you provide example

[Adityapanther]

@mcollina no need to use fastify.inject in test

[mcollina]

What this PR is missing to ship are a few tests, one for each of the new formats, that:

1. create an endpoint that uses the selected format, inside the route it validates what is the payload that is sent
2. performs a valid http request to the endpoint
3. performs a http request that would fail validation

Thanks

[CarterLi]

Any progress?

[Adityapanther]

I am currently busy with my company, I will update this sunday

[ec2ainun]

any update?

[CarterLi]

any update?

He said he would update it this sunday. Lets be patient

[ec2ainun]

any update?

He said he would update it this sunday. Lets be patient

okay im sorry, i'm new here, but i think its already a month isn't it? @CarterLi

[CarterLi]

any update?

He said he would update it this sunday. Lets be patient

okay im sorry, i'm new here, but i think its already a month isn't it? @CarterLi

I was joking...

[Adityapanther]

@ec2ainun I am quite busy in my life I am trying to manage my work and personal life, if anyone free here he can provide update to this pull otherwise I will provide update after my project finish

[ec2ainun]

@Adityapanther sorry, i have little knowledge about openapi spec implementation, i just look around how to create good documentation in order to upload file using fastify, and i found this pull request in discussion

[Adityapanther]

@mcollina please review

[mcollina]

It does not seem to include all the tests I asked before.

[Adityapanther]

@mcollina added use strict

[mcollina]

What this PR is missing to ship are a few tests, one for each of the new formats, that:

1. create an endpoint that uses the selected format, inside the route it validates what is the payload that is sent
2. performs a valid http request to the endpoint
3. performs a http request that would fail validation

Thanks

I think these tests are still missing.
CI is also failing.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.