Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat documentation authorization #466

Merged
merged 4 commits into from
Sep 15, 2021
Merged

feat documentation authorization #466

merged 4 commits into from
Sep 15, 2021

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Sep 14, 2021

closes #465

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1233934815

  • 0 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1232986798: 0.0%
Covered Lines: 549
Relevant Lines: 549
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 14, 2021 •
edited

Pull Request Test Coverage Report for Build 1236879824

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1232986798: 0.0%
Covered Lines: 549
Relevant Lines: 549
💛 - Coveralls

zekth
zekth requested changes Sep 14, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor rewording remarks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Eomm @zekth
Apply suggestions from code review
8d7e608 
Co-authored-by: Vincent LE GOFF <vince.legoff@gmail.com>
Fdawgs
Fdawgs reviewed Sep 14, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mcollina
Copy link
Member

@Eomm could you take a look?

mcollina
mcollina approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm @Fdawgs
Update README.md
94e43e8 
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
climba03003
climba03003 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina requested a review from zekth September 15, 2021 09:07
@mcollina
Copy link
Member

@zekth you good?

zekth
zekth approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Eomm Eomm merged commit 1a68013 into master Sep 15, 2021
@Eomm Eomm deleted the feat-auth-hook branch September 15, 2021 09:39
fertolg added a commit to fertolg/fastify-swagger-ui that referenced this pull request Mar 18, 2023
@fertolg
Add docs for protecting the documentation routes
6b164d4 
When @fastify/swagger-ui was part of @fastify/swagger there used to be documentation for protecting the documentation routes, but that wasn't transferred over when [it was removed](fastify/fastify-swagger@f15bebd#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L689) it seems.

I know I've spent a bit of time searching for how to do this, stumbling upon fastify/fastify-swagger#466 and getting confused when the docs are not there anymore in the current HEAD.

I think it would be beneficial to add this to the fastify-swagger-ui docs since it's a very common use case.
@fertolg fertolg mentioned this pull request Mar 18, 2023
Merged
4 tasks
mcollina pushed a commit to fastify/fastify-swagger-ui that referenced this pull request Mar 23, 2023
@fertolg @Uzlopak
Add docs for protecting the documentation routes (#47)
bf84b4d 
* Add docs for protecting the documentation routes

When @fastify/swagger-ui was part of @fastify/swagger there used to be documentation for protecting the documentation routes, but that wasn't transferred over when [it was removed](fastify/fastify-swagger@f15bebd#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L689) it seems.

I know I've spent a bit of time searching for how to do this, stumbling upon fastify/fastify-swagger#466 and getting confused when the docs are not there anymore in the current HEAD.

I think it would be beneficial to add this to the fastify-swagger-ui docs since it's a very common use case.

* Update README.md

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

* Update README.md

Add a better example using constant-time comparison to prevent timing attacks

---------

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@zekth zekth zekth approved these changes

@climba03003 climba03003 climba03003 approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fastify-swagger: protect access of Swagger UI
6 participants
@Eomm @coveralls @mcollina @zekth @climba03003 @Fdawgs