Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format param url #511

Merged
merged 3 commits into from
Dec 9, 2021
Merged

fix: format param url #511

merged 3 commits into from
Dec 9, 2021

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented Dec 8, 2021

Fixes #510
I am a bit tired on updating the regexp to accept a lot of different format of param.
I reverted back to use a single for-loop

Notable Changes:

  1. it support non-named regexp
  2. it support *

Both of the above cases use auto-generated param name.

Checklist

@coveralls
Copy link

coveralls commented Dec 8, 2021

Pull Request Test Coverage Report for Build 1553482251

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 45 of 45 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1529840142: 0.0%
Covered Lines: 616
Relevant Lines: 616

💛 - Coveralls

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good idea!

Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm good work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Params with regex breaking docs
5 participants