-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi): support patternProperties #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change it on swagger
side?
Pull Request Test Coverage Report for Build 1583864045Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I can do it but I m not a daily user of swagger specs. @climba03003 Sounds good for you? |
Yes, you can apply the same fix. |
@climba03003 I did it, expecting as you wish :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
This PR solve #165 issue.
The idea is to transform the patternProperties into a valid OpenAPI definition. We lost the precision in public documentation but validation still done on server side
Checklist
npm run test
andnpm run benchmark
and the Code of conduct