-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenApi: Fix params mapping on relative URL #520
Conversation
Pull Request Test Coverage Report for Build 1628361882
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1628361882Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code should be linted.
Not sure what do you mean by "linted", I used |
@@ -67,7 +67,7 @@ function prepareOpenapiObject (opts) { | |||
} | |||
|
|||
function normalizeUrl (url, servers, stripBasePath) { | |||
if (!stripBasePath) return url | |||
if (!stripBasePath) return formatParamUrl(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
nevermind, things were scrambled on mobile. |
Fix for a bug, when
stripBasePath
is disabled and openApi is configured. it will not map path params to fastify params.Checklist
npm run test
andnpm run benchmark
and the Code of conduct