-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rendering the syntax of different content types responses #665
feat: rendering the syntax of different content types responses #665
Conversation
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
You can change&push temporary the package.json to use your fastify branch:
so we will check the green ci |
Signed-off-by: iifawzi <iifawzie@gmail.com>
Nice to know, committed. |
Signed-off-by: iifawzi <iifawzie@gmail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the misspelling please 😄
Signed-off-by: iifawzi <iifawzie@gmail.com>
<br> | ||
<br> | ||
Different content types responses are supported by `@fastify/swagger` and `@fastify`. | ||
Please use `content` for the response otherwise Fastify itself will fail to compile the schema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use `content` for the response otherwise Fastify itself will fail to compile the schema: | |
Use `content` for the response otherwise Fastify itself will fail to compile the schema: |
Nothing to please here ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
is used everywhere in the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind removing it though
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
since fastify/fastify#4264 is finally finished :D, CI should be green here, and then can be merged |
Signed-off-by: iifawzi <iifawzie@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Signed-off-by: iifawzi <iifawzie@gmail.com>
committed @Uzlopak suggestions, and temporarily updated the packages to check ci. |
Fastify v4.9.0 shipped. |
Signed-off-by: iifawzi <iifawzie@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: iifawzi iifawzie@gmail.com
resolving #117
As per fastify/fastify#4264, swagger should support different content types responses.
Tests here will fail until the feature is merged at
fastify
, but I've hard-codded thefastify
proposed changes and tested it.Checklist
npm run test
andnpm run benchmark
and the Code of conduct