Fix race condition that have the spec cached if .swagger() is called before ready() #757

mcollina · 2023-09-19T10:36:01Z

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

…before .ready() Signed-off-by: Matteo Collina <hello@matteocollina.com>

Uzlopak

LGTM

Fix race condition that have the spec cached if .swagger() is called …

c8e69f3

…before .ready() Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina requested review from Uzlopak, climba03003 and ivan-tymoshenko September 19, 2023 10:36

mcollina changed the title ~~Fix race condition that have the spec cached if .swagger() is called …~~ Fix race condition that have the spec cached if .swagger() is called before ready() Sep 19, 2023

ivan-tymoshenko approved these changes Sep 19, 2023

View reviewed changes

kibertoad approved these changes Sep 19, 2023

View reviewed changes

mcollina mentioned this pull request Sep 19, 2023

Always call .ready() before calling .swagger() platformatic/platformatic#1529

Merged

Uzlopak approved these changes Sep 19, 2023

View reviewed changes

Uzlopak merged commit 6b0b563 into master Sep 19, 2023
17 checks passed

Uzlopak deleted the fix-race-condition branch September 19, 2023 11:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix race condition that have the spec cached if .swagger() is called before ready() #757

Fix race condition that have the spec cached if .swagger() is called before ready() #757

mcollina commented Sep 19, 2023 •

edited

Uzlopak left a comment

Fix race condition that have the spec cached if .swagger() is called before ready() #757

Fix race condition that have the spec cached if .swagger() is called before ready() #757

Conversation

mcollina commented Sep 19, 2023 • edited

Checklist

Uzlopak left a comment

Choose a reason for hiding this comment

mcollina commented Sep 19, 2023 •

edited