Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for webhooks option according to Open Api 3.1.0 #760

Merged
merged 2 commits into from
Oct 5, 2023
Merged

feat: support for webhooks option according to Open Api 3.1.0 #760

merged 2 commits into from
Oct 5, 2023

Conversation

bun913
Copy link
Contributor

@bun913 bun913 commented Oct 3, 2023

Closes #728

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
    • Since there is already an explanation of OpenApi options, I thought it unnecessary to add it to the README.
  • commit message and code follows the Developer's Certification of Origin
    and the Code of conduct

@bun913 bun913 changed the title Support for webhooks option according to Open Api 3.1.0 feat: support for webhooks option according to Open Api 3.1.0 Oct 3, 2023
mcollina
mcollina approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bun913
Copy link
Contributor Author

bun913 commented Oct 5, 2023

@mcollina

I apologize for the interruption during your busy schedule, but would it still be difficult to merge this?

@kibertoad kibertoad merged commit 8be4a0d into fastify:master Oct 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support OpenAPI Webhooks
3 participants
@bun913 @mcollina @kibertoad