fix: issues with Windows file path #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 5, 2022 21:13
on production builds, check if windows, if is windows do a dynamic import using the file path.
on production builds, check if windows, if is windows do a dynamic import using the file path.
2 tasks
galvez
changed the title
|
LGTM, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are for better windows file system support.
I changed the build:server script to use "./index.js" as opposed to "/index.js"
I changed the root in the vite.config.js in the example projects to use the relative file path "./client" as windows and *nix systems file paths are different.
I changed the production file to check if it's windows and use the file path instead of the file url if it is. Windows esm loader requires file path.