fixup! fix: reply object not marked as sent for stream payloads (#3318)

lib/reply.js

@@ -13,7 +13,6 @@ const {
   kReplyHasStatusCode,
   kReplyIsRunningOnErrorHook,
   kReplyNextErrorHandler,
-  kReplySent,
   kDisableRequestLogging
 } = require('./symbols.js')
 const { hookRunner, hookIterator, onSendHookRunner } = require('./hooks')
@@ -415,8 +414,6 @@ function onSendEnd (reply, payload) {
   }
 
   if (typeof payload.pipe === 'function') {
-    reply[kReplySent] = true
-
     sendStream(payload, res, reply)
     return
   }

test/stream.test.js

@@ -14,7 +14,7 @@ const JSONStream = require('JSONStream')
 const send = require('send')
 const Readable = require('stream').Readable
 const split = require('split2')
-const { kDisableRequestLogging, kReplySent } = require('../lib/symbols.js')
+const { kDisableRequestLogging } = require('../lib/symbols.js')
 
 test('should respond with a stream (success)', t => {
   t.plan(6)
@@ -646,39 +646,3 @@ test('should destroy stream when response is ended', t => {
     })
   })
 })
-
-test('should mark reply as sent before pumping the payload stream into response for async route handler', t => {
-  t.plan(3)
-
-  const handleRequest = proxyquire('../lib/handleRequest', {
-    './wrapThenable': (thenable, reply) => {
-      thenable.then(function (payload) {
-        t.equal(reply[kReplySent], true)
-      })
-    }
-  })
-
-  const route = proxyquire('../lib/route', {
-    './handleRequest': handleRequest
-  })
-
-  const Fastify = proxyquire('..', {
-    './lib/route': route
-  })
-
-  const fastify = Fastify()
-
-  fastify.get('/', async function (req, reply) {
-    const stream = fs.createReadStream(__filename, 'utf8')
-    reply.code(200).send(stream)
-  })
-
-  fastify.inject({
-    url: '/',
-    method: 'GET'
-  }, (err, res) => {
-    t.error(err)
-    t.equal(res.payload, fs.readFileSync(__filename, 'utf8'))
-    fastify.close()
-  })
-})