Skip to content

Commit

Permalink
Minor improvements to docs and a comment (#2940)
Browse files Browse the repository at this point in the history
  • Loading branch information
tniessen committed Mar 18, 2021
1 parent c5d950d commit 701804c
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -63,7 +63,7 @@ Welcome to the team! We are happy to have you. Before you start, please complete
- [GitHub 2FA](https://help.github.com/en/articles/securing-your-account-with-two-factor-authentication-2fa)
- [NPM 2FA](https://docs.npmjs.com/about-two-factor-authentication)
2. Choose which team to join *(more than one is ok!)* based on how you want to help.
3. Open a pull request to [`fastify/fastify:master`](https://github.com/fastify/fastify/pulls) that adds your name, username, and email to the team you have choosen in the [README.md](./README.md) and [package.json](./package.json) *(if you are part of the core team)* files. The members lists are sorted alphabetically; make sure to add your name in the proper order.
3. Open a pull request to [`fastify/fastify:master`](https://github.com/fastify/fastify/pulls) that adds your name, username, and email to the team you have chosen in the [README.md](./README.md) and [package.json](./package.json) *(if you are part of the core team)* files. The members lists are sorted alphabetically; make sure to add your name in the proper order.
4. Open a pull request to [`fastify/website:master`](https://github.com/fastify/website/pulls) adding yourself to the [team.yml](https://github.com/fastify/website/blob/master/src/website/data/team.yml) file. This list is also sorted alphabetically so make sure to add your name in the proper order. Use your GitHub profile icon for the `picture:` field.
5. The person that does the onboarding must add you to the [npm org](https://www.npmjs.com/org/fastify), so that you can help maintaining the official plugins.

Expand Down
2 changes: 1 addition & 1 deletion docs/Migration-Guide-V3.md
Expand Up @@ -267,7 +267,7 @@ fastify.get('/', (request, reply) => {

## Further additions and improvements

- Hooks now have consistent context irregardless of how they are registered
- Hooks now have consistent context regardless of how they are registered
([#2005](https://github.com/fastify/fastify/pull/2005))
- Deprecated `request.req` and `reply.res` for [`request.raw`](Request.md) and
[`reply.raw`](Reply.md) ([#2008](https://github.com/fastify/fastify/pull/2008))
Expand Down
2 changes: 1 addition & 1 deletion docs/Server.md
Expand Up @@ -191,7 +191,7 @@ fastify.addHook('onResponse', (req, reply, done) => {
})
```

Please note that this setting will also disable an error log written by the the default `onResponse` hook on reply callback errors.
Please note that this setting will also disable an error log written by the default `onResponse` hook on reply callback errors.

<a name="custom-http-server"></a>
### `serverFactory`
Expand Down
2 changes: 1 addition & 1 deletion docs/Style-Guide.md
Expand Up @@ -163,7 +163,7 @@ Here is how your hyperlink should look:
```MD
<!-- More like this -->

// Add clear & breif description
// Add clear & brief description
[Fastify Plugins] (https://www.fastify.io/docs/latest/Plugins/)

<!--Less like this -->
Expand Down
2 changes: 1 addition & 1 deletion fastify.js
Expand Up @@ -540,7 +540,7 @@ function fastify (options) {

// Most devs do not know what to do with this error.
// In the vast majority of cases, it's a network error and/or some
// config issue on the the load balancer side.
// config issue on the load balancer side.
this.log.trace({ err }, 'client error')

// If the socket is not writable, there is no reason to try to send data.
Expand Down

0 comments on commit 701804c

Please sign in to comment.