Fixes #451

fastify · Nov 11, 2017 · 8c528ba · 8c528ba
1 parent ff40e9a
commit 8c528ba
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/fastify.js b/fastify.js
@@ -573,8 +573,9 @@ function build (options) {
   }
 
   function setNotFoundHandler (opts, handler) {
-    this.after(() => {
+    this.after((notHandledErr, done) => {
       _setNotFoundHandler.call(this, opts, handler)
+      done(notHandledErr)
     })
   }
 

diff --git a/test/404s.test.js b/test/404s.test.js
@@ -421,3 +421,25 @@ test('hooks check 404', t => {
     })
   })
 })
+
+test('Issue #451', t => {
+  t.plan(1)
+
+  const fastify = Fastify()
+
+  fastify.get('/', function (req, reply) {
+    reply.send({ hello: 'world' })
+  })
+
+  fastify.get('/', function (req, reply) {
+    reply.send({ hello: 'world' })
+  })
+
+  fastify.setNotFoundHandler(function (req, reply) {
+    reply.code(404).send('this was not found')
+  })
+
+  fastify.listen(0, err => {
+    t.ok(err)
+  })
+})