Suspected dead code in listenPromise

[trivikr]

You have already researched for similiar issues?

Yes

Are you sure this is an issue with the fastify or are you just looking for some help?

This seems to be a dead code in fastify

Is this a security related issue?

No

What are you trying to achieve or the steps to reproduce?

I was trying to add a test for covering the following line

fastify/fastify.js

Line 314 in 6bce249

address = address || 'localhost'

I noticed that the address can never be undefined as it's set to '127.0.0.1' is calling function

fastify/fastify.js

Lines 347 to 359 in 6bce249

	if (typeof address === 'function') {
	cb = address
	address = undefined
	}
	address = address || '127.0.0.1'
	/* Deal with listen (port, address, cb) */
	if (typeof backlog === 'function') {
	cb = backlog
	backlog = undefined
	}
	if (cb === undefined) return listenPromise(port, address, backlog)

What did you expect?

Is the check on the following line redundant?

fastify/fastify.js

Line 314 in 6bce249

address = address || 'localhost'

[mcollina]

Go ahead and remove it, it seems a duplicate!

[trivikr]

The address = address || 'localhost' supposedly fixed the 500ms delay issue on Windows which was discussed and fixed in #1047

However, the current issue existed when the fix was introduced

Should '127.0.0.1' change to 'localhost' on line 351?

fastify/fastify.js

Line 351 in 6bce249

address = address || '127.0.0.1'

[mcollina]

Yes it should. Actually, would you mind to refactor that check in just one place?

[trivikr]

Fix posted in PR #1102