Reply send Method Does Not Set 204 Status

[wooliet]

Documentation for Reply states that not sending any content results in 204 status response.

https://github.com/fastify/fastify/blob/master/docs/Reply.md#code

If not settled via reply.code, the resulting statusCode will be 200 or 204 if there is not content to send.

I don't think this is the case, but I might be missing something.

reply.js #37

if (payload === undefined) {
  if (!this.res.statusCode) {
    this.res.statusCode = 204
  }

From what I can tell, res.statusCode will already be set to 200 (its default value). So calling reply.send() will send status 200 and not 204.

If the above is correct, I believe the relevant portion of the documentation should be removed.

[mcollina]

Good spot! I tend to say the code is assuming too much and it should not attach a status code. Would you mind sending a PR?

[nileshmali]

@mcollina You mean we should remove below block and update docs?

if (!this.res.statusCode) {
  this.res.statusCode = 204
}

[mcollina]

Yes.