There are no type descriptions for server properties

[budarin]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.0.0-rc.3

Description

There are no type descriptions for server properties:

• pluginName
  https://www.fastify.io/docs/latest/Reference/Server/#pluginname

• validatorCompiler
  https://www.fastify.io/docs/latest/Reference/Server/#validatorcompiler

• serializerCompiler
  https://www.fastify.io/docs/latest/Reference/Server/#serializercompiler

It is possible that other instance properties are not typed

Steps to Reproduce

Expected Behavior

Availability of type descriptions for the specified properties

[mcollina]

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

[budarin]

By the way, they are not present at all in the instance of fastify

const fastify = require('fastify')({
    logger: true,
});

// Declare a route
fastify.get('/', function (req, reply) {
    const { pluginName, validatorCompiler, serializerCompiler } = fastify;

    req.log.info(`${typeof pluginName}, ${typeof validatorCompiler}, ${typeof serializerCompiler}`);

    reply.send({ hello: 'world' });
});

here are the log entries

{"level":30,"time":1653837768101,"pid":25388,"hostname":"WIN-40K96OG4L3A","msg":"Server listening at http://127.0.0.1:3000"}
{"level":30,"time":1653837770753,"pid":25388,"hostname":"WIN-40K96OG4L3A","reqId":"req-1","req":{"method":"GET","url":"/","hostname":"127.0.0.1:3000","remoteAddress":"127.0.0.1","remotePort":55850},"msg":"incoming request"}
{"level":30,"time":1653837770755,"pid":25388,"hostname":"WIN-40K96OG4L3A","reqId":"req-1","msg":"undefined, undefined, undefined"}
{"level":30,"time":1653837770770,"pid":25388,"hostname":"WIN-40K96OG4L3A","reqId":"req-1","res":{"statusCode":200},"responseTime":15.357467889785767,"msg":"request completed"}

[mcollina]

pluginName is expected to be undefined for the root object. I'm going to change it to 'fastify' so that's it's clearer.

As for validatorCompiler and serializerCompiler I'm unsure. I tried to play around and I got a few undefined too. Take a look at https://github.com/fastify/fastify/blob/main/test/schema-feature.test.js, it should provide some guidance. @Eomm wdyt?

[mcollina]

@Eomm could you look into validatorCompiler and serializerCompiler?

[Eomm]

Yes, those types are missing and only the input is mapped actually

[TommyDew42]

Hi, is @budarin working on this issue? If we need someone to work on it, I’m happy to help!!

[mcollina]

@TommyDew42 I think you can take it!

[budarin]

@TommyDew42

Unfortunately I don't know enough about the internal implementation of fastify to solve this problem (

[denes-fekeshazy]

Looks like there is a merged PR for this. Should this issue be closed or is there more work to do on this?