Wrong typings for hooks on route options

[brettwillis]

The in the snippet below, the hook types are a union of two identical types like onRequestHookHandler<...> | onRequestHookHandler<...> etc, and this excludes the async hook type, which should be valid to use here, right?

Are these supposed to be onRequestHookHandler<...> | onRequestAsyncHookHandler<...>, etc?

fastify/types/route.d.ts

Lines 48 to 56 in 5c75f49

	onRequest?: onRequestHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | onRequestHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	preParsing?: preParsingHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | preParsingHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	preValidation?: preValidationHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | preValidationHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	preHandler?: preHandlerHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | preHandlerHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	preSerialization?: preSerializationHookHandler<unknown, RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | preSerializationHookHandler<unknown, RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	onSend?: onSendHookHandler<unknown, RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | onSendHookHandler<unknown, RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	onResponse?: onResponseHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | onResponseHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	onTimeout?: onTimeoutHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> | onTimeoutHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>[];
	onError?: onErrorHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, FastifyError, SchemaCompiler, TypeProvider, Logger> | onErrorHookHandler<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, FastifyError, SchemaCompiler, TypeProvider, Logger>[];

[mcollina]

likely so!
Would you like to send a Pull Request to address this issue? Remember to add unit tests.

[aradwann]

It's a union between a onRequestHookHandler<...> (single value ) and a onRequestHookHandler<..>[] (array of values )

[brettwillis]

Ah yes you're right. @mcollina @aradwann do you still want a PR to include the async version in those types?

While we're at it, are there any thoughts about the non-standard camel-case naming of those types?

[mcollina]

Ah yes you're right. @mcollina @aradwann do you still want a PR to include the async version in those types?

Given my understanding, yes, we should update this. Would you like to send a PR?

While we're at it, are there any thoughts about the non-standard camel-case naming of those types?

We probably didn't know there was a standard. Could you link?
I would not change any types name right now - maybe open a separate issue? We might consider it for the next major.

[aradwann]

@mcollina i don't if google style guide is followed here, according to https://google.github.io/styleguide/tsguide.html#identifiers class / interface / type / enum / decorator / type parameters should use UpperCamelCase
I see that most types/interfaces are written in UpperCamelCase here so I think onSendHookHandler should be OnSendHookHandler for consistency

[ismailmmd]

Hey, I have created a PR for above issue. 🙏 please review