Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #1034

Merged
merged 5 commits into from
Jul 13, 2018
Merged

Fix links #1034

merged 5 commits into from
Jul 13, 2018

Conversation

lmammino
Copy link
Member

@lmammino lmammino commented Jul 10, 2018

This change fixes documentation links for the website as discussed in fastify/website#72

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@lmammino lmammino added the documentation Improvements or additions to documentation label Jul 10, 2018
@lmammino lmammino self-assigned this Jul 10, 2018
Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmammino
Copy link
Member Author

Good finding @allevo! It should be ok now!

@allevo
Copy link
Member

allevo commented Jul 11, 2018

@lmammino the link is disappeared.

https://github.com/fastify/fastify/blob/1b038b2281306f887b4ac40d355d55276e055ab0/docs/Logging.md

And why should we use the absolute link?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@mcollina mcollina merged commit 35b3202 into master Jul 13, 2018
@mcollina mcollina deleted the fix/docs-links branch July 13, 2018 11:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants