-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links #1034
Fix links #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broken the markdown rendering.
See https://github.com/fastify/fastify/blob/79cd71450a4dc6c8a70f3a0358288f47350b9abf/docs/Logging.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good finding @allevo! It should be ok now! |
@lmammino the link is disappeared. https://github.com/fastify/fastify/blob/1b038b2281306f887b4ac40d355d55276e055ab0/docs/Logging.md And why should we use the absolute link? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This change fixes documentation links for the website as discussed in fastify/website#72
Checklist
runnpm run test
andnpm run benchmark
tests and/or benchmarks are included