Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fastify-jwt-webapp #1141

Merged
merged 1 commit into from
Sep 21, 2018
Merged

added fastify-jwt-webapp #1141

merged 1 commit into from
Sep 21, 2018

Conversation

charlesread
Copy link
Contributor

No description provided.

trivikr
trivikr approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina reviewed Sep 6, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some issues on the plugin, I would prefer them to be addressed before landing this.

@charlesread
Copy link
Contributor Author

@mcollina , thank you very much for the very valid critiques; I truly find them quite valuable! I'll be sure to address them all.

@delvedor delvedor added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Sep 6, 2018
@charlesread
Copy link
Contributor Author

@mcollina , I have addressed all of the issues that you created, and improved the plugin as a result, thanks! I will soon add integration testing.

@charlesread charlesread closed this Sep 6, 2018
@charlesread charlesread reopened this Sep 6, 2018
@charlesread
Copy link
Contributor Author

@mcollina , please see the resolutions to your issues, as well as fairly robust testing (still working toward 100% coverage), at your convenience for approval, thanks!

mcollina
mcollina approved these changes Sep 9, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemremengu cemremengu merged commit 01687a8 into fastify:master Sep 21, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@charlesread @mcollina @trivikr @cemremengu @delvedor