Fix missing object wrapper for errors in pino log #1180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log is a pino logger, the first argument is a mapping, so in order to give it an error object, we must give it an object with an
err
field, otherwise the error object itself is dissected as if it were a mapping.This commit fixes places where this has been forgotten.
I only changed source files, not test files because it's not a big deal there.
Checklist
npm run test
andnpm run benchmark
npm run benchmark
exits this way on my machine, on my branch just like on master:Benchmarking such a change makes no sense anyway.