Custom querystring

[delvedor]

Implementation of what has been proposed in #1268.

We are also dropping the use of url.parse, so this change will be flagged as semver-major.
With this change, the querystring parsing is twice faster than before 🚀

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[jsumners]

Given that this is a semver major, I agree that we should be using the URL function instead of querystring. Better to migrate to the future at once instead of over multiple releases.

[mcollina]

LGTM

The reason why we are doing this is to remove url.parse. That is the library that is deprecated and should not really be used.

Parsing the querystring via new URL is unfortunately an harder change, as the result is exposed as a Map-like object. We need to pass that into our schema validator, and I fear we cannot use that with some good throughput yet.

(IMHO this is not semver-major, url.parse use querystring internally).

[jsumners]

Okay.

[StarpTech]

LGTM

[allevo]

This feature is not plugin encapsulated. Is there a reason for it?

[delvedor]

This feature is not plugin encapsulated. Is there a reason for it?

1. We want to ship it in the first RC, add a new API to allow encapsulation could be done in a semver minor feature.
2. Generally speaking usually the default querystring parser is enough, so we expose a simple way to override it without adding a brand new API.

[mcollina]

This feature is not plugin encapsulated. Is there a reason for it?

I think there are only so many ways that a querystring could be converted to JS objects. Within a single HTTP server, those should be the same throughout the system. It's kind of the same reason why caseSensitive is in the options https://www.fastify.io/docs/latest/Server/#casesensitive.

We could make this encapsulated, but I'm not convinced it would be worthwhile. I might be wrong.

[cemremengu]

LGTM very nice feature 👍

[mcollina]

LGTM, good work

[nwoltman]

LGTM

[jannikkeye]

Please update the typings in the future if flags are added. Since the typings are shipped with fastify they should be updated with every change made. I would understand not updating them if types were shipped via @types.

[delvedor]

@jannikkeye pr are welcome!

[jsumners]

@jannikkeye the Fastify project relies on the TypeScript community to maintain the typings. The majority of the Fastify core team does not know TypeScript.

[0xZaycev]

thanks for this update)))))))))

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.