Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add links to Errors.md #1326

Merged
merged 4 commits into from Dec 17, 2018
Merged

doc: add links to Errors.md #1326

merged 4 commits into from Dec 17, 2018

Conversation

fralonra
Copy link
Member

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@fralonra fralonra mentioned this pull request Dec 14, 2018
Closed
cemremengu
cemremengu approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cemremengu
cemremengu reviewed Dec 14, 2018
View reviewed changes
README.md Show resolved Hide resolved
@cemremengu cemremengu added the documentation Improvements or additions to documentation label Dec 14, 2018
@fralonra
Copy link
Member Author

I have renamed th file to Error-Codes.md

mcollina
mcollina approved these changes Dec 15, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor reviewed Dec 15, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpopular opinion, why not add the error types inside the error handling doc instead of creating two different documents?

@mcollina
Copy link
Member

I'm also ok with that.

@fralonra
Copy link
Member Author

@delvedor If we do that, is it better to change the filename from Error Handling to something else, Errors for example.

@delvedor
Copy link
Member

@fralonra agreed, go for it! :)

@fralonra
Copy link
Member Author

New doc has made. :P

delvedor
delvedor approved these changes Dec 16, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Dec 16, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cemremengu
cemremengu approved these changes Dec 16, 2018
View reviewed changes
Copy link
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 1ad553d into fastify:master Dec 17, 2018
@fralonra fralonra deleted the patch-3 branch December 17, 2018 08:50
@fralonra fralonra mentioned this pull request Dec 17, 2018
Open
21 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@cemremengu cemremengu cemremengu approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fralonra @mcollina @delvedor @cemremengu