Feature/encapsulation json schema #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
approved these changes
Jan 7, 2019
docs/Validation-and-Serialization.md
Outdated
| @@ -50,7 +50,7 @@ fastify.post('/the/url', { schema }, handler) | |||
|
|
|||
| <a name="shared-schema"></a> | |||
| #### Adding a shared schema | |||
| Thanks to the `addSchema` API, you can add multiple schemas to the Fastify instance and then reuse them in multiple parts of your application. *(Note that this API is not encapsulated)* | |||
| Thanks to the `addSchema` API, you can add multiple schemas to the Fastify instance and then reuse them in multiple parts of your application. As usual this API is encapsulated. | |||
There was a problem hiding this comment.
Suggested change
| Thanks to the `addSchema` API, you can add multiple schemas to the Fastify instance and then reuse them in multiple parts of your application. As usual this API is encapsulated. | |
| Thanks to the `addSchema` API, you can add multiple schemas to the Fastify instance and then reuse them in multiple parts of your application. As usual, this API is encapsulated. |
There was a problem hiding this comment.
Can you also add an example of using this functionality in an encapsulated way?
There was a problem hiding this comment.
Done 馃憤 Let me know if it is clear 馃
Co-Authored-By: Eomm <behemoth89@gmail.com>
This was referenced Jan 16, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkHi, I'm opening this PR for the issue #1351.
I have tried to follow the logic of middleware (for the children update) and hooks (for the
buildHooks) to implement this feature.Now each fastify instance will have a private
Schemasobject that is replicated when another instance is created (viafastify.build.override())I have added some tests that seem logical to me, let me know if there are other cases to cover that I didn't spot.
I have one doubt regarding how I have implemented the
.getSchemas, replicating the function declaration onfunction overridebut I don't found a better way.I'll wait for your precious feedback 馃槂
Thank you