Update default ajv instance to include all errors

[cemremengu]

Closes #1397

Set allErrors: true in default AJV instance to catch all errors

Checklist

• run npm run test
• run npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[mcollina]

LGTM, I’m in favor of this change.

[mcollina]

(only for v2)

[delvedor]

Out of curiosity, can you also post a benchmark?

[cemremengu]

I don't trust myself or my environment with benchmarks so would be great if someone double check this. 😄 There seems to be no change but it also depends on the size and complexity of the schema I guess.

Using sample

'use strict'

const fastify = require('../fastify')()

const schema = {
  body: {
    type: 'object',
    properties: {
      name: { type: 'string' },
      work: { type: 'string' }
    },
    required: ['name', 'work']
  }
}

fastify.post('/', { schema }, function (req, reply) {
  reply.send({ hello: 'world' })
})

fastify.listen(3000)

Before

PS C:\Users\cemre.mengu\Desktop\fastify> npx autocannon -m POST -H "content-type=application/json" -b "{}" -c 100 -d 5 -p 10 localhost:3000
Running 5s test @ http://localhost:3000
100 connections with 10 pipelining factor

┌─────────┬──────┬──────┬───────┬────────┬─────────┬──────────┬──────────┐
│ Stat    │ 2.5% │ 50%  │ 97.5% │ 99%    │ Avg     │ Stdev    │ Max      │
├─────────┼──────┼──────┼───────┼────────┼─────────┼──────────┼──────────┤
│ Latency │ 0 ms │ 0 ms │ 90 ms │ 110 ms │ 8.73 ms │ 26.65 ms │ 237.4 ms │
└─────────┴──────┴──────┴───────┴────────┴─────────┴──────────┴──────────┘
┌───────────┬─────────┬─────────┬─────────┬────────┬────────┬─────────┬─────────┐
│ Stat      │ 1%      │ 2.5%    │ 50%     │ 97.5%  │ Avg    │ Stdev   │ Min     │
├───────────┼─────────┼─────────┼─────────┼────────┼────────┼─────────┼─────────┤
│ Req/Sec   │ 9031    │ 9031    │ 11839   │ 11903  │ 11236  │ 1112.09 │ 9029    │
├───────────┼─────────┼─────────┼─────────┼────────┼────────┼─────────┼─────────┤
│ Bytes/Sec │ 2.66 MB │ 2.66 MB │ 3.48 MB │ 3.5 MB │ 3.3 MB │ 327 kB  │ 2.65 MB │
└───────────┴─────────┴─────────┴─────────┴────────┴────────┴─────────┴─────────┘

Req/Bytes counts sampled once per second.

0 2xx responses, 56183 non 2xx responses
56k requests in 5.08s, 16.5 MB read

After

PS C:\Users\cemre.mengu\Desktop\fastify> npx autocannon -m POST -H "content-type=application/json" -b "{}" -c 100 -d 5 -p 10 localhost:3000
Running 5s test @ http://localhost:3000
100 connections with 10 pipelining factor

┌─────────┬──────┬──────┬───────┬───────┬────────┬──────────┬───────────┐
│ Stat    │ 2.5% │ 50%  │ 97.5% │ 99%   │ Avg    │ Stdev    │ Max       │
├─────────┼──────┼──────┼───────┼───────┼────────┼──────────┼───────────┤
│ Latency │ 0 ms │ 0 ms │ 86 ms │ 93 ms │ 8.4 ms │ 25.54 ms │ 171.58 ms │
└─────────┴──────┴──────┴───────┴───────┴────────┴──────────┴───────────┘
┌───────────┬─────────┬─────────┬─────────┬─────────┬─────────┬────────┬─────────┐
│ Stat      │ 1%      │ 2.5%    │ 50%     │ 97.5%   │ Avg     │ Stdev  │ Min     │
├───────────┼─────────┼─────────┼─────────┼─────────┼─────────┼────────┼─────────┤
│ Req/Sec   │ 10855   │ 10855   │ 11855   │ 12391   │ 11666.4 │ 652.06 │ 10852   │
├───────────┼─────────┼─────────┼─────────┼─────────┼─────────┼────────┼─────────┤
│ Bytes/Sec │ 3.19 MB │ 3.19 MB │ 3.49 MB │ 3.64 MB │ 3.43 MB │ 192 kB │ 3.19 MB │
└───────────┴─────────┴─────────┴─────────┴─────────┴─────────┴────────┴─────────┘

Req/Bytes counts sampled once per second.

0 2xx responses, 58327 non 2xx responses
58k requests in 5.08s, 17.1 MB read

[delvedor]

You should test a case where you have multiple schema failures :)

[cemremengu]

@delvedor I was not kidding when I said you shouldn't trust me 😄

Updated the previous comment

[nwoltman]

This is a good idea 👍

[mcollina]

I would prefer to run benchmakrs myself before landing

[mcollina]

LGTM this is not regressing anything

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.