Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover all hooks functionality #1424

Merged
merged 1 commit into from Jan 31, 2019
Merged

Cover all hooks functionality #1424

merged 1 commit into from Jan 31, 2019

Conversation

cemremengu
Copy link
Contributor

More tests to cover all hooks functionality. Fix a test name as well.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemremengu cemremengu merged commit 4c3dd86 into master Jan 31, 2019
@cemremengu cemremengu deleted the hooks-tests branch January 31, 2019 21:40
@cemremengu
Copy link
Contributor Author

Badge is not updated yet but looks like we hit theoretical 100% 🎉

@delvedor delvedor added the test Issue or pr related to our testing infrastructure. label Feb 5, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cemremengu @mcollina @delvedor