Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query option #1442

Merged
merged 3 commits into from
Feb 9, 2019
Merged

Add query option #1442

merged 3 commits into from
Feb 9, 2019

Conversation

arniu
Copy link
Contributor

@arniu arniu commented Feb 9, 2019

Add query option after upgrade light-my-request to v3.2.0

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Add `query` option after upgrade `light-my-request` to v3.2.0
Add `query` option after upgrade `light-my-request` to v3.2.0
fastify.d.ts Outdated
@@ -281,6 +281,7 @@ declare namespace fastify {
method?: HTTPMethod,
authority?: string,
headers?: object,
query?: object,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use DefaultQuery type for headers and query.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a DefaultHeaders...

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added documentation Improvements or additions to documentation typescript TypeScript related labels Feb 9, 2019
Copy link
Member

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech merged commit 356cf6f into fastify:master Feb 9, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants