Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated find-my-way to v2 #1453

Merged
merged 3 commits into from
Feb 17, 2019
Merged

Updated find-my-way to v2 #1453

merged 3 commits into from
Feb 17, 2019

Conversation

delvedor
Copy link
Member

As titled, the behavior of caseSensitive has changed, I've added two more tests to verify that.

This should not be backported to v1.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@delvedor delvedor added semver-major Issue or PR that should land as semver major chore Small changes or internal project maintenance labels Feb 17, 2019
@delvedor delvedor requested a review from a team February 17, 2019 18:26
jsumners
jsumners approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 5647291 into master Feb 17, 2019
@jsumners jsumners deleted the find-my-way-v2 branch February 17, 2019 18:45
@cemremengu
Copy link
Contributor

A vulnerability is reported for fmv v2

https://snyk.io/test/github/fastify/fastify

@delvedor
Copy link
Member Author

Thank you @cemremengu, I’ll give it a look tomorrow.

In the meantime, we should add to our CI a vulnerability scanner :)

@delvedor
Copy link
Member Author

Opened davisjam/safe-regex#23, if the fix will not come quickly enough, we’ll downgrade to a previous version.
In any case, it is not a critical problem for us since is a function the we run only at startup and not during the normal lifecycle of our application.

@fralonra fralonra mentioned this pull request Feb 18, 2019
Open
21 tasks
@mcollina
Copy link
Member

We now have https://github.com/fastify/safe-regex2, which is a fork of safe-regex at 1.1.0, the last version released by substack.

@mcollina
Copy link
Member

I've added Snyk

@delvedor delvedor mentioned this pull request Feb 18, 2019
Merged
@delvedor
Copy link
Member Author

Update: we have published find-my-way v2.0.1 with the security fix and deprecated v2.0.0.

@fralonra fralonra mentioned this pull request Feb 27, 2019
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
chore Small changes or internal project maintenance semver-major Issue or PR that should land as semver major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delvedor @cemremengu @mcollina @jsumners