Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a README #17

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Added a README #17

merged 1 commit into from
Oct 17, 2016

Conversation

mcollina
Copy link
Member

@delvedor please review.

@delvedor
Copy link
Member

Looks perfect!

Maybe move Request inside "Route Callback" with Reply.

* <a href="#get"><code>fastify.<b>get()</b></code></a>
* <a href="#post"><code>fastify.<b>post()</b></code></a>
* <a href="#put"><code>fastify.<b>put()</b></code></a>
* <a href="#request"><code>fastify.<b>Request</b></code></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be confusing, since Request is not accessibile via fastify.Request.

@mcollina mcollina merged commit 631d35e into master Oct 17, 2016
@mcollina mcollina deleted the readme branch October 17, 2016 13:43
@delvedor delvedor mentioned this pull request Oct 17, 2016
haggholm pushed a commit to haggholm/fastify that referenced this pull request Jun 12, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants