Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor docs update for https typings #1945

Merged
merged 1 commit into from Dec 5, 2019
Merged

minor docs update for https typings #1945

merged 1 commit into from Dec 5, 2019

Conversation

ziimakc
Copy link

@ziimakc ziimakc commented Nov 19, 2019

Added docs comment for correct use of typings for https server:
"// For https pass http2.Http2SecureServer or http.SecureServer instead of Server."

Added docs comment for correct use of typings for https server:
"// For https pass http2.Http2SecureServer or http.SecureServer instead of Server."
@Eomm Eomm added the typescript TypeScript related label Nov 19, 2019
@stale
Copy link

stale bot commented Dec 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue or pr with more than 15 days of inactivity. label Dec 4, 2019
@stale stale bot removed the stale Issue or pr with more than 15 days of inactivity. label Dec 5, 2019
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit c8828c4 into fastify:master Dec 5, 2019
theliuk pushed a commit to theliuk/fastify that referenced this pull request Dec 13, 2019
Added docs comment for correct use of typings for https server:
"// For https pass http2.Http2SecureServer or http.SecureServer instead of Server."
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants