New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix - docs - hooks - error handling #2000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the try-catches and rethrow altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @mcollina.
(1):
or
|
|
Alright, in a moment. |
Changing as requested
😕 In "files changed" show me an alteration that I already did it 321c6b6. I think that is a bug of Github. |
Same here, I saw just before I send the PR. Without knowing what to do, I keeped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix - docs - hooks - error handling * Update Hooks.md Changing as requested * Fix - docs - FluentSchema - link * fix - docs - readme - reqs/sec
* Docs(Fluent-Schema.md): fix fluent schema repo link (#2007) * fix - docs - hooks - error handling (#2000) * fix - docs - hooks - error handling * Update Hooks.md Changing as requested * Fix - docs - FluentSchema - link * fix - docs - readme - reqs/sec * add fastify-explorer to ecosystem (#2003) * Add a recommendations doc (#1997) * Add a recommendations doc * Update docs/Recommendations.md * Fix TOC typo in recommendations (#2009) * docs(Typescript): typo (#2016) * docs: fix onResponse parameter (#2020) Co-authored-by: Vitaliy Abramov <i@kassad.ru> Co-authored-by: Wallas F Morais <wallas@fmorais.com.br> Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Co-authored-by: James Sumners <james@sumners.email> Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Checklist
npm run test
andnpm run benchmark