Add docs to stop processing hooks with async #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Feb 4, 2020
jsumners
reviewed
Feb 6, 2020
Co-Authored-By: James Sumners <james@sumners.email>
Eomm
reviewed
Feb 6, 2020
| @@ -2727,6 +2727,27 @@ test('onRegister hook should be called / 4', t => { | |||
| }) | |||
| }) | |||
|
|
|||
| test('early termination, onRequest', t => { | |||
There was a problem hiding this comment.
Is a test for early termination with the signature (request, reply, done) already in place?
There was a problem hiding this comment.
Yes
Line 1213 in c052c21
Co-Authored-By: Manuel Spigolon <behemoth89@gmail.com>
|
@Eomm are you ok? |
Eomm
approved these changes
Feb 6, 2020
This was referenced Feb 8, 2020
This was referenced Mar 20, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2075
Checklist
npm run testandnpm run benchmark