Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for issue #2148 where typedefs for query params object were wrong #2149

Merged
merged 2 commits into from
Mar 24, 2020
Merged

test for issue #2148 where typedefs for query params object were wrong #2149

merged 2 commits into from
Mar 24, 2020

Conversation

rburgst
Copy link
Contributor

@rburgst rburgst commented Mar 20, 2020

this is a breaking test that illustrates #2148 . It should pass once the issue is fixed

Checklist

  • run npm run test and npm run benchmark (fails obviously)
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@Eomm Eomm added test Issue or pr related to our testing infrastructure. typescript TypeScript related labels Mar 20, 2020
@mcollina
Copy link
Member

Could you send a PR to https://github.com/fastify/light-my-request?

@rburgst
Copy link
Contributor Author

rburgst commented Mar 23, 2020

once fastify/light-my-request#76 is merged this test should go through

@rburgst
Copy link
Contributor Author

rburgst commented Mar 24, 2020

waiting for next release of https://github.com/fastify/light-my-request, now that fastify/light-my-request#76 was merged

mcollina
mcollina approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the new release of light-my-request is out.

Ethan-Arrowood
Ethan-Arrowood approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉great work on this thank you!

@rburgst
Copy link
Contributor Author

rburgst commented Mar 24, 2020

who will merge this PR? I dont have the permissions.

mcollina
mcollina approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 15d1721 into fastify:master Mar 24, 2020
@mcollina
Copy link
Member

Thanks!

@rburgst rburgst mentioned this pull request Mar 26, 2020
Closed
This was referenced May 5, 2020
Merged
Merged
Closed
Merged
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
test Issue or pr related to our testing infrastructure. typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rburgst @mcollina @Ethan-Arrowood @Eomm @rburgstaller