Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to fastify-qrcode into Ecosystem #2170

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add to fastify-qrcode into Ecosystem #2170

merged 1 commit into from
Apr 2, 2020

Conversation

chonla
Copy link
Contributor

@chonla chonla commented Apr 1, 2020

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina reviewed Apr 1, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

@chonla
Copy link
Contributor Author

chonla commented Apr 2, 2020

Added.

@Eomm Eomm added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Apr 2, 2020
delvedor
delvedor requested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you also remove the lockfile? In packages using lockfiles could be harmful as their dependencies will never get updated in case of a security fix.

@chonla
Copy link
Contributor Author

chonla commented Apr 2, 2020

Done. Thank you for pointing that out. :)

@chonla chonla requested a review from delvedor April 2, 2020 09:55
delvedor
delvedor approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit cf6c975 into fastify:master Apr 2, 2020
This was referenced May 5, 2020
Merged
Merged
Closed
Merged
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina left review comments

@delvedor delvedor delvedor approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chonla @mcollina @delvedor @Eomm